search

GoogleCloudPlatform / esp-v2

A service proxy that provides API management capabilities using Google Service Infrastructure.
https://cloud.google.com/endpoints/
Apache License 2.0
268 stars 167 forks source link

Propagate Api Key UID when it is returned by the service controller. #892

Closed Elliot-xq closed 5 months ago

Elliot-xq commented 5 months ago

Propagates the API key UID if it is returned in the service controller CheckResponse.

If it is not returned by the CheckResponse, we will still use the api_key as it is.

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elliot-xq, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/esp-v2/blob/master/OWNERS)~~ [TAOXUY] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.

google-oss-prow[bot] commented 5 months ago

@Elliot-xq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-gke-e2e-grpc-echo-managed 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-gke-e2e-grpc-echo-managed
ESPv2-gke-e2e-http-bookstore-managed 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-gke-e2e-http-bookstore-managed
ESPv2-gke-e2e-grpc-interop-managed 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-gke-e2e-grpc-interop-managed
ESPv2-gke-e2e-http-bookstore-managed-using-sa-cred 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-gke-e2e-http-bookstore-managed-using-sa-cred
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
ESPv2-cloud-run-e2e-app-engine-http-bookstore 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-cloud-run-e2e-app-engine-http-bookstore
ESPv2-presubmit-tsan 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-presubmit-tsan
ESPv2-presubmit-asan 408e97e5242804d604a2e029092cf2db0d432203 link true /test ESPv2-presubmit-asan
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).