search

GoogleCloudPlatform / esp-v2

A service proxy that provides API management capabilities using Google Service Infrastructure.
https://cloud.google.com/endpoints/
Apache License 2.0
268 stars 167 forks source link

Add a flag to opt out reporting api key uid and report unknown in network error. #897

Closed Elliot-xq closed 4 months ago

Elliot-xq commented 5 months ago

1) adds flag service_control_report_api_key_uid with default false. TODO: enable it before release.

2) reports unknown in check request network failure.

Elliot-xq commented 4 months ago

Nit: add an integration test later https://github.com/GoogleCloudPlatform/esp-v2/blob/master/tests/integration_test/service_control_apikey_location_test/service_control_apikey_location_test.go

sure, will do it in another change.

Elliot-xq commented 4 months ago

/retest-required

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elliot-xq, shuoyang2016, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/esp-v2/blob/master/OWNERS)~~ [TAOXUY,shuoyang2016] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 4 months ago

New changes are detected. LGTM label has been removed.

Elliot-xq commented 4 months ago

/retest-required

google-oss-prow[bot] commented 4 months ago

@Elliot-xq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-tsan b6995b13261b34be206c35febd14cbea6e7adc57 link true /test ESPv2-presubmit-tsan
ESPv2-presubmit-asan b6995b13261b34be206c35febd14cbea6e7adc57 link true /test ESPv2-presubmit-asan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore b6995b13261b34be206c35febd14cbea6e7adc57 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).