search

GoogleCloudPlatform / esp-v2

A service proxy that provides API management capabilities using Google Service Infrastructure.
https://cloud.google.com/endpoints/
Apache License 2.0
272 stars 170 forks source link

Refactor httpRuleToHTTPPattern to public #915

Closed sunaydagli closed 3 months ago

sunaydagli commented 3 months ago

Make the httpRuleToHTTPPattern public for use outside the routegen package.

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elliot-xq, sunaydagli Once this PR has been reviewed and has the lgtm label, please assign shuoyang2016 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/esp-v2/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 3 months ago

@sunaydagli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-tsan b3d72e5bdd13cb64f4bc3b38095330d89e7180e2 link true /test ESPv2-presubmit-tsan
ESPv2-presubmit-asan b3d72e5bdd13cb64f4bc3b38095330d89e7180e2 link true /test ESPv2-presubmit-asan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore b3d72e5bdd13cb64f4bc3b38095330d89e7180e2 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).