search

GoogleCloudPlatform / eventarc-samples

This repository contains a collection of samples for Eventarc for various use cases.
Apache License 2.0
74 stars 34 forks source link

"Cloud Deployment Manager" should be "Cloud Deploy" #97

Closed camiekim closed 1 year ago

camiekim commented 1 year ago

"Cloud Deployment Manager" is being output as a heading twice. The first instance should be "Cloud Deploy".

meteatamel commented 1 year ago

Hi @camiekim, we pull in AuditLog events from another repo from this file: https://raw.githubusercontent.com/googleapis/google-cloudevents/master/json/audit/service_catalog.json

So, it needs to be fixed there. Not sure who's in charge of that repo though.

meteatamel commented 1 year ago

I'm closing this as we can't do anything in this repo. I suggest you reach out to the folks in google-cloudevents repo

camiekim commented 1 year ago

Ok, thanks, Mete. Opened an issue here: https://github.com/googleapis/google-cloudevents/issues/441

averikitsch commented 1 year ago

Once https://github.com/googleapis/google-cloudevents/issues/441 is merged, then the generator can be run again.

meteatamel commented 1 year ago

Verified that the events list is generated with "Cloud Deploy now". Closing it.