search

GoogleCloudPlatform / firebase-extensions

Apache License 2.0
74 stars 36 forks source link

neighbours arg not passed from HTTP request of firestore-semantic-search #389

Closed MetcalfeTom closed 6 months ago

MetcalfeTom commented 6 months ago

According to the query_index source code, we should be able to pass an integer number for the number of neighbours returned.

Somehow, this doesn't work when requesting the endpoint, e.g.

{"data": {"query": ["this is a test"], "neighbours": 30}}

Still only returns 10 results. Can this be investigated?

https://github.com/GoogleCloudPlatform/firebase-extensions/blob/b718308cfde2ef71108ac7c26ae5ad67aa4f6ab9/firestore-semantic-search/functions/src/functions/query_index.ts#L35

MetcalfeTom commented 6 months ago

I see it was already rasied in https://github.com/GoogleCloudPlatform/firebase-extensions/issues/282

pr-Mais commented 6 months ago

@MetcalfeTom we're investigating it, thanks for raising! will keep track on #282

jauntybrain commented 6 months ago

This issue has been resolved with PR #391.