search

GoogleCloudPlatform / firebase-extensions

Apache License 2.0
74 stars 36 forks source link

fix(firestore-vector-search): allow array values for prefilter #515

Open Harlan-Epoch opened 3 months ago

Harlan-Epoch commented 3 months ago

Currently if you try to use the "in" operator with an array value in a prefilter you get an invalid argument error. By updating line 20 like I have, the function now accepts the array.

InvokeInnovationsInc commented 3 months ago

im excited for this! I was wondering why I couldn't do this

Harlan-Epoch commented 3 months ago

im excited for this! I was wondering why I couldn't do this

Hey! Well if you don't mind managing it yourself you can edit the source code in your google console to exactly what I commented and it will work. Not sure why it didn't pass the tests. I'm running it in production with no errors. You can add functionality for booleans as well in the same line.

Juraj333 commented 3 months ago

im excited for this! I was wondering why I couldn't do this Well, I can't pass the test for beginner developers

pr-Mais commented 1 month ago

@Harlan-Epoch thanks for adding this! tests seems to be failing, could you check and apply necessary updates.