GoogleCloudPlatform / flaky-service

🥐a service for collecting and tracking flaky tests
Apache License 2.0
16 stars 9 forks source link

factor: delete unused api code #238

Closed StuartRucker closed 4 years ago

StuartRucker commented 4 years ago

Deleted code and tests for /api/repo and for POST /api/buid, along with accompanying test cases

An additional small fix to throw an error when repoid is null when posting data. This error was because decodeURIComponent of a null value returns an 'undefined' string.

Also, no longer checks if repo is private.

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

bcoe commented 4 years ago

I believe this got a little screwed up during the process of resolving conflicts, let's not merge yet.

bcoe commented 4 years ago

closing in favor of: https://github.com/GoogleCloudPlatform/flaky-service/pull/272