GoogleCloudPlatform / flaky-service

🥐a service for collecting and tracking flaky tests
Apache License 2.0
16 stars 9 forks source link

Get rid of `ok, not ok` in testrun.js constructor #258

Closed cedpeters closed 4 years ago

cedpeters commented 4 years ago

The testrun constructor (https://github.com/GoogleCloudPlatform/flaky-service/blob/master/packages/api/lib/testrun.js) accepts a string, which is either ok or not ok, and then immediately converts it into a boolean. Fix it so that it just accepts a boolean in the first place. This will involve changing all the places where the constructor is called.