search

GoogleCloudPlatform / flaky-service

🥐a service for collecting and tracking flaky tests
Apache License 2.0
16 stars 9 forks source link

passing boolean instead of ok/not ok string for testrun constructor #263

Closed rbrishabh closed 4 years ago

rbrishabh commented 4 years ago

Fixes #258

Hey @cedpeters, please let me know if this needs any changes and I'll be happy to make them!

Thanks!

bcoe commented 4 years ago

@rbrishabh thank you for the contribution 😄

@cedpeters let me know when you're ready with review? I believe tests are failing due to a permission issue with GitHub actions, nothing to do with the PR.

cedpeters commented 4 years ago

@bcoe sounds good! As far as I'm concerned it looks good to go, my nits are just style suggestions. I can make a small PR for fixing the invalid constructor call in tap-parser.js, because that was my mistake and not introduced in this PR.

rbrishabh commented 4 years ago

If you want, I can quickly push both those changes in this PR only @cedpeters

rbrishabh commented 4 years ago

Actually, I'm on it right now! Happy to contribute :)

cedpeters commented 4 years ago

I wrote a small PR to fix the bug I introduced, but it's having some issues with the cla that I'll need to figure out. Might just be simpler for you to do it. https://github.com/GoogleCloudPlatform/flaky-service/pull/264

rbrishabh commented 4 years ago

@cedpeters this is ready for another review! Thanks!

bcoe commented 4 years ago

@rbrishabh sounds like this is ready to land, as soon as you address @cedpeters' last comment and resolve the merge conflict 👍

rbrishabh commented 4 years ago

@bcoe I think this is ready

bcoe commented 4 years ago

@rbrishabh thank you for the contribution 👌

rbrishabh commented 4 years ago

My pleasure! I'll be happy to keep contributing @bcoe, so if you think there's anything I can do to help, just tag @rbrishabh and I'll be there!