Closed EnriqueL8 closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for the PR! But I feel this might not be the best solution to the problem. Can we first investigate whether it can be solved by upgrading controller-gen version? or using kustomize patch? Thanks!
@functicons should I raise another PR with kustomize?
Fixes #311. Very difficult task to do with
sed
orawk
, could be done in Golang but sinceyq
used Golang it's simpler. Could add ayq
binary to the repo so users don't have to download it.