GoogleCloudPlatform / flink-on-k8s-operator

[DEPRECATED] Kubernetes operator for managing the lifecycle of Apache Flink and Beam applications.
Apache License 2.0
658 stars 266 forks source link

Fix kube 1.18 #331

Closed EnriqueL8 closed 3 years ago

EnriqueL8 commented 3 years ago

Fixes #311. Very difficult task to do with sed or awk, could be done in Golang but since yq used Golang it's simpler. Could add a yq binary to the repo so users don't have to download it.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

functicons commented 3 years ago

Thanks for the PR! But I feel this might not be the best solution to the problem. Can we first investigate whether it can be solved by upgrading controller-gen version? or using kustomize patch? Thanks!

EnriqueL8 commented 3 years ago

@functicons should I raise another PR with kustomize?