Closed yaron-idan closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@functicons, here's the PR. Please reviewe.
/gcbrun
Could you update the helm chart installation guide with this change? e.g., the default namespace, users can specify namespace and how. https://github.com/GoogleCloudPlatform/flink-on-k8s-operator/blob/master/helm-chart/flink-operator/README.md
Yeah, that makes sense. I've updated the readme file to reflect the new use case.
/gcbrun
Signed-off-by: Yaron Idan yaronidan@gmail.com
Closes #348
I chose to stick with the convention seen in the rest of the chart and move the namespace name and create flag under the
flinkOperatorNamespace
key. This choice is a breaking change for anyone using a non-default namespace name, if you think it's too much I can leave both keys in the root level of the values file.