search

GoogleCloudPlatform / flink-on-k8s-operator

[DEPRECATED] Kubernetes operator for managing the lifecycle of Apache Flink and Beam applications.
Apache License 2.0
658 stars 266 forks source link

Add recreate component options for update cluster #365

Closed DeliangFan closed 3 years ago

DeliangFan commented 3 years ago

related-issue: #360

elanv commented 3 years ago

@DeliangFan @functicons What about recreateOnUpdate (true/false) or updatePolicy (updateComponent/ recreateComponent) than recreateComponent to express straightforward?

elanv commented 3 years ago

I think it would be good to merge this PR after issue #294 is resolved because updating job cluster will be failed with this PR. I am going to create a PR to resolve the issue within few days.

DeliangFan commented 3 years ago

@DeliangFan @functicons What about recreateOnUpdate (true/false) or updatePolicy (updateComponent/ recreateComponent) than recreateComponent to express straightforward?

Good idea, and I would replace it with recreateOnUpdate.

functicons commented 3 years ago

Is this PR ready for review? Does it depend on the work of @elanv to be submitted first?

elanv commented 3 years ago

Is this PR ready for review? Does it depend on the work of @elanv to be submitted first?

I think so because there is recovery bug of job cluster.

functicons commented 3 years ago

@DeliangFan could you sync and resolve the conflicts? I'll review the PR after that, thanks!

DeliangFan commented 3 years ago

@DeliangFan could you sync and resolve the conflicts? I'll review the PR after that, thanks!

Hi, @functicons , a new PR has been pushed, please take a review, thanks a lot.

functicons commented 3 years ago

@DeliangFan could you sync and resolve the conflicts? I'll review the PR after that, thanks!

Hi, @functicons , a new PR has been pushed, please take a review, thanks a lot.

Sorry for the delay, I'm just back from vacation. Will review it soon.

functicons commented 3 years ago

Could you also update the CRD doc for the new field?

DeliangFan commented 3 years ago

Could you also update the CRD doc for the new field?

@functicons , a new has been updated, please take a review, thanks.

functicons commented 3 years ago

/gcbrun