search

GoogleCloudPlatform / flink-on-k8s-operator

[DEPRECATED] Kubernetes operator for managing the lifecycle of Apache Flink and Beam applications.
Apache License 2.0
658 stars 266 forks source link

Why there is no nodeSelector in spec level or in Job in CRD? #380

Open chethanuk opened 3 years ago

chethanuk commented 3 years ago

Why there is no nodeSelector in spec level or in Job in latest crd?

Having node selector in Job also will be helpful or at spec level will be much better

Also, there is no option to set affinity and anti affinity

yanghui16355 commented 3 years ago

+1 for including affinity and anti affinity in CRD

functicons commented 3 years ago

Yeah, that's something we missed in the past, it should be added.

functicons commented 3 years ago

@ChethanUK Do you want to make a PR for it?

the-cybersapien commented 3 years ago

@functicons Is this still in ToDos or is someone working on it? Would like to work on this if it's not taken by someone else yet.

chethanuk commented 3 years ago

@the-cybersapien I got busy with something else, I missed this. You can pick up this.

sgraham785 commented 3 years ago

created a PR #423 for this, as well as #422 which adds affinity to the jobmanager & taskmanager specs. apologies if I stepped on anyone's toes here