GoogleCloudPlatform / flink-on-k8s-operator

[DEPRECATED] Kubernetes operator for managing the lifecycle of Apache Flink and Beam applications.
Apache License 2.0
658 stars 265 forks source link

Helm chart is buggy #428

Open ghost opened 3 years ago

ghost commented 3 years ago

I have ran into a few bugs, so just globbing them all here.

Bug 1:

$ helm install flink flink/flink-operator --set operatorImage.name=gcr.io/flink-operator/flink-operator:latest

$ kubectl get pods -n flink-operator-system 
NAME                                                 READY   STATUS              RESTARTS   AGE
cert-job-rsbmx                                       0/1     Error               0          9s
flink-operator-controller-manager-5b5f5fcd95-txrvz   0/2     ContainerCreating   0          9s

cert-job has an error, output:

from server for: "STDIN": secrets "webhook-server-cert" is forbidden: User "system:serviceaccount:flink-operator-system:default" cannot get resource "secrets" in API group "" in the namespace "flink-operator-system"

:point_up: a basic vanilla install doesn't seem to work at all.

Trying to install into a namespace:

$ helm install flink flink/flink-operator --set operatorImage.name=gcr.io/flink-operator/flink-operator:latest --set flinkOperatorNamespace.name=test --set flinkOperatorNamespace.create=true
index.go:339: skipping loading invalid entry for chart "flink-operator" "v1beta1" from /home/a/.cache/helm/repository/flink-index.yaml: validation: chart.metadata.version "v1beta1" is invalid
index.go:339: skipping loading invalid entry for chart "flink-operator" "v1alpha1" from /home/a/.cache/helm/repository/flink-index.yaml: validation: chart.metadata.version "v1alpha1" is invalid
coalesce.go:163: warning: skipped value for flinkOperatorNamespace: Not a table.
Error: Namespace "map[create:true name:test]" is invalid: metadata.name: Invalid value: "map[create:true name:test]": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
gkocur commented 3 years ago

The same here. Moreover - I checked the templates files and - if I read it correctly - it always tries to create a namespace, regardless flinkOperatorNamespace.create is set to true of false.

ghost commented 3 years ago

@gkocur see fork, I fixed the chart to work with v3. Give that a shot.

elanv commented 3 years ago

This issue is related to #352.

If you want to fix the Helm chart, you should update the .circleci/release.sh or kustomize templates, because the Helm chart is generated via CI process. Or, if there is a good idea, it would be nice to improve the Helm chart release process.

streetmapp commented 3 years ago

It also doesn't look like the repo for the hlem chart is updating properly. Because there are only a few versions of the chart available and contains issues that I think are resolved by some of the changes that are in master. So I don't know that the .circleci/release.sh script is working as intended.