Open nlu90 opened 3 years ago
Hi,
I just ran make generate against the master branch with latest commit:
make generate
commit 0310df76d6e2128cd5d2bc51fae4e842d370c463 (HEAD -> master, origin/master, origin/HEAD) Author: GoogleCloudPlatform <hg1068@nyu.edu> Date: Sun Feb 28 21:07:18 2021 +0000 Update helm chart CRD (Auto generated by CircleCI)
And got the following changes:
diff --git a/api/v1beta1/zz_generated.deepcopy.go b/api/v1beta1/zz_generated.deepcopy.go index dc36e1d..5685306 100644 --- a/api/v1beta1/zz_generated.deepcopy.go +++ b/api/v1beta1/zz_generated.deepcopy.go @@ -494,6 +494,13 @@ func (in *JobManagerSpec) DeepCopyInto(out *JobManagerSpec) { (*in)[i].DeepCopyInto(&(*out)[i]) } } + if in.VolumeClaimTemplates != nil { + in, out := &in.VolumeClaimTemplates, &out.VolumeClaimTemplates + *out = make([]v1.PersistentVolumeClaim, len(*in)) + for i := range *in { + (*in)[i].DeepCopyInto(&(*out)[i]) + } + } if in.InitContainers != nil { in, out := &in.InitContainers, &out.InitContainers *out = make([]v1.Container, len(*in)) @@ -577,7 +584,7 @@ func (in *JobSpec) DeepCopyInto(out *JobSpec) { **out = **in } if in.TakeSavepointOnUpgrade != nil { - in, out := &in.TakeSavepointOnUpgrade, &out.takeSavepointOnUpgrade + in, out := &in.TakeSavepointOnUpgrade, &out.TakeSavepointOnUpgrade *out = new(bool) **out = **in } @@ -774,6 +781,13 @@ func (in *TaskManagerSpec) DeepCopyInto(out *TaskManagerSpec) { (*in)[i].DeepCopyInto(&(*out)[i]) } } + if in.VolumeClaimTemplates != nil { + in, out := &in.VolumeClaimTemplates, &out.VolumeClaimTemplates + *out = make([]v1.PersistentVolumeClaim, len(*in)) + for i := range *in { + (*in)[i].DeepCopyInto(&(*out)[i]) + } + } if in.InitContainers != nil { in, out := &in.InitContainers, &out.InitContainers *out = make([]v1.Container, len(*in))
It looks like this generated file needs to be updated regarding some new fields.
Not ideal, but the following PR (v1 API) does have the fix: https://github.com/GoogleCloudPlatform/flink-on-k8s-operator/pull/436
Hi,
I just ran
make generate
against the master branch with latest commit:And got the following changes:
It looks like this generated file needs to be updated regarding some new fields.