GoogleCloudPlatform / fluent-plugin-detect-exceptions

A fluentd plugin that scans line-oriented log streams and combines exceptions stacks into a single log entry.
Apache License 2.0
192 stars 69 forks source link

Feature/adding the parameter add line break #68

Closed elaurendeau closed 4 years ago

elaurendeau commented 4 years ago

The goal of this PR is to add a way to enable automated line break between each line of the stack trace.

The docker's fluentd logging forwarder, is removing the line break between each exception line. Without this feature, you get the entire stacktrace on one line.

To use this feature, you must use the optional boolean parameter "add_line_break". By default, it will be set to false to make sure the integration of this feature is transparent for the current users.

Without the add_line_break feature: image

With the add_line_break freature: image

` \ @type forward port 24224 bind 0.0.0.0 @label @RAW \

\<label @RAW> \<match **> @type detect_exceptions languages java message log multiline_flush_interval 1.0 add_line_break true @label @COOKED \ \

\<label @COOKED> \<match **> @type splunk_hec ... \ \ `

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

elaurendeau commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.