search

GoogleCloudPlatform / functions-framework-java

FaaS (Function as a service) framework for writing portable Java functions
Apache License 2.0
133 stars 63 forks source link

fix: avoid executing function when /favicon.ico or /robots.txt is called #226

Closed alsoba13 closed 11 months ago

alsoba13 commented 1 year ago

Proposed change to fix https://github.com/GoogleCloudPlatform/functions-framework-java/issues/225.

As explained in the issue, the solution is based on other Jetty handlers: InetAccessHandler.java

Regarding tests, the integration tests were passing because they just check that 404 is returned, but they miss to check that function is not invoked.

I think that an extra test checking that part would be nice, but the current test framework API won't let me easily check that. I may extend a bit the test framework to add this test if you agree.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

alsoba13 commented 11 months ago

Thank you!

Just a simple doubt. Once the new version is released, how much time it may take to see the fix on production gcp?