search

GoogleCloudPlatform / functions-framework-java

FaaS (Function as a service) framework for writing portable Java functions
Apache License 2.0
130 stars 63 forks source link

chore(main): release java-function-invoker 1.3.1 #237

Closed garethgeorge closed 10 months ago

garethgeorge commented 10 months ago

Reattempt java-function-invoker 1.3.1 release.

conventional-commit-lint-gcf[bot] commented 10 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

kenneth-rosario commented 10 months ago

@garethgeorge Another release please pr was created for v1.3.1: https://github.com/GoogleCloudPlatform/functions-framework-java/pull/234

Which should we merge?

garethgeorge commented 10 months ago

Good catch, thanks Kenneth. This one includes fixes and should be merged -- we can safely close the other if the release works this time.

An alternative would be patching the fixes in this PR into the release-please bot's new PR. Happy to defer to either approach if you have a preference w.r.t. which seems safer.

kenneth-rosario commented 10 months ago

Lets use this one. The only thing is the release job will need to be triggered manually but that should be straight forward.