GoogleCloudPlatform / functions-framework-nodejs

FaaS (Function as a service) framework for writing portable Node.js functions
Apache License 2.0
1.29k stars 158 forks source link

Disable Express eTag response header for consistent FF behaviour across FF runtimes #433

Closed cstanger closed 2 years ago

cstanger commented 2 years ago

The Express.js framework handles [eTags] (https://expressjs.com/en/api.html#app.settings.table) by default. Therefore, will respond with HTTP 304 Not Modified when a known eTag header value is present in a request with the same response.

In all other Function Framework runtime implementations, this behavior is not implemented, and this caching behavior, which can be considered as an implementation detail, could be explicitly addressed by a developer as needed.

This pull request aims make the NodeJs runtime version behaving the same as runtime implementations for GO, Java, Ruby, .Net Core, Python, and PHP.