search

GoogleCloudPlatform / functions-framework-nodejs

FaaS (Function as a service) framework for writing portable Node.js functions
Apache License 2.0
1.28k stars 158 forks source link

update readme.md to include ESM example #587

Closed blazing234 closed 2 months ago

blazing234 commented 5 months ago

update readme.md to include ESM example

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

conventional-commit-lint-gcf[bot] commented 5 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

blazing234 commented 5 months ago

@kenneth-rosario Would this type of PR be able to be approved? I want to edit the cloud docs in general to include more ESM examples

matthewrobertson commented 2 months ago

We have a guide in docs that described how to use ESM: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/main/docs/esm.md

I don't think we want to pull this into the main README as we want to keep in minimal.