search

GoogleCloudPlatform / functions-framework-php

FaaS (Function as a service) framework for writing portable PHP functions
Apache License 2.0
212 stars 37 forks source link

Integration tests aren't compatible with rennovatebot #162

Open josephlewis42 opened 1 year ago

josephlewis42 commented 1 year ago

Rennovatebot isn't creating branches on the local repository, so the conformance tests which require this are failing. It's likely they will also fail for other external PRs as well.

https://github.com/GoogleCloudPlatform/functions-framework-php/blob/5b645eedc7508a16481c364e8cd209fb176d3e03/tests/conformance/prerun.sh#L25

We should instead direct the integration tests to point at the currently checked out source in the GitHub action's pipeline. Perhaps something like this: https://stackoverflow.com/questions/29994088/composer-require-local-package

josephlewis42 commented 1 year ago

Pinging @kenneth-rosario for GitHub Action knowledge, I think composer can use local files, but we might also be able to reference the remote repository in the prerun. Not sure which is best with pack involved.