GoogleCloudPlatform / functions-framework

The Contract for Building New Function Frameworks
Apache License 2.0
123 stars 11 forks source link

docs: add declarative function's framework signature configuration to FF contract #54

Closed grant closed 2 years ago

grant commented 2 years ago

It's important to keep the main contract up-to-date for all frameworks to adhere to.

Fixes https://github.com/GoogleCloudPlatform/functions-framework/issues/53

grant commented 2 years ago

Ping @matthewrobertson

matthewrobertson commented 2 years ago

Can we add a section that explains the relative precedence of configurations? I think it should be:

  1. in source code configurations
  2. command line flags
  3. environment variables
grant commented 2 years ago

Fine merging over ping.

Can we add a section that explains the relative precedence of configurations? I think it should be:

  1. in source code configurations
  2. command line flags
  3. environment variables

Sounds good, I updated the section talking about this with more detail.

https://github.com/GoogleCloudPlatform/functions-framework/pull/54/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L178