search

GoogleCloudPlatform / gcloud-maven-plugin

Cloud SDK Maven Plugin for Google App Engine (Managed VMs and non Managed VMs)
Apache License 2.0
29 stars 24 forks source link

Mark as deprecated #101

Closed meltsufin closed 7 years ago

meltsufin commented 8 years ago

@arouzrokh @ludoch PTAL

arouzrokh commented 8 years ago

:shipit:

ludoch commented 8 years ago

None of the github Cloud samples are using the new plugin, so let's wait for when they are updated (and tested with the new plugin). It seems that the public doc is sometimes affected by the same pattern (doc not aligned with samples).

On Mon, Aug 29, 2016 at 4:30 PM, Amir Rouzrokh notifications@github.com wrote:

'Ship it'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gcloud-maven-plugin/pull/101#issuecomment-243288997, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4zToSHD1vPonrR20WEOkuYe0bn00oks5qk2uwgaJpZM4JuHTV .

meltsufin commented 8 years ago

The public docs have been updates, but I'm not sure what is the state of the samples. @lesv

ludoch commented 8 years ago

I think this is the core of the issue. For example, If I follow the public doc for Jetty9 compat, I end up with a failed tutorial, mixing the 2 things.

On Tue, Aug 30, 2016 at 6:48 AM, meltsufin notifications@github.com wrote:

The public docs have been updates, but I'm not sure what is the state of the samples. @lesv https://github.com/lesv

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gcloud-maven-plugin/pull/101#issuecomment-243444111, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4zeOMWIYEghig4PMblvLN0WZLqcyLks5qlDSlgaJpZM4JuHTV .

lesv commented 8 years ago

Some docs are confused -- they will be fixed today.

lesv commented 7 years ago

This shouldn't happen yet -- Endpoints v2 requires a feature here.

meltsufin commented 7 years ago

The old appengine-maven-plugin supports endpoints. That plugin is not being deprecated yet. So, I don't think there is a feature gap if this plugin is deprecated. @arouzrokh

lesv commented 7 years ago

This is for the NEW endpoints, and there will be other features where this is important.

This is about the gcloud maven plugin deprecation.

arouzrokh commented 7 years ago

@lesv I think with the latest updates, we can push ahead with marking this as deprecated? let me know what else is remaining (with the exception of Beta flag which for now is tabled because we are thinking of a different strategy, possibly a beta plugin, for beta releases)

lesv commented 7 years ago

We are close, just not yet. We haven't released the new EP plugins.

arouzrokh commented 7 years ago

We've pretty much updated all branches and for GAE Standard we are still supporting the old plugin here: https://github.com/GoogleCloudPlatform/appengine-maven-plugin

Please merge this PR. Thanks.

meltsufin commented 7 years ago

@ludoch ping... can you please merge this?