search

GoogleCloudPlatform / gcp-service-broker

Open Service Broker for Google Cloud Platform
Apache License 2.0
142 stars 59 forks source link

Can't push the broker on latest buildpack versions because go 1.14 is gone #570

Closed dsboulder closed 2 years ago

dsboulder commented 2 years ago

Similar to #563, I currently cannot install the broker on the latest buildpack version because the version of golang is no longer supported. Here's the log:

             2021-10-20T23:33:14.59+0000 [STG/0] OUT -----> Go Buildpack version 1.9.34  
             2021-10-20T23:33:14.59+0000 [STG/0] OUT        [31;1m**WARNING**[0m buildpack version changed from 1.9.26 to 1.9.34  
             2021-10-20T23:33:14.59+0000 [STG/0] OUT        [31;1m**WARNING**[0m [DEPRECATION WARNING]:  
             2021-10-20T23:33:14.59+0000 [STG/0] OUT        [31;1m**WARNING**[0m Please use AppDynamics extension buildpack for Golang Application instrumentation  
             2021-10-20T23:33:14.59+0000 [STG/0] OUT        [31;1m**WARNING**[0m for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html  
             2021-10-20T23:33:14.60+0000 [STG/0] OUT -----> Installing godep 80  
             2021-10-20T23:33:14.60+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/52a892f00e80ca4fdcf27d9828c7aba1/godep-v80-linux-x64-cflinuxfs3-b60ac947.tgz]  
             2021-10-20T23:33:14.86+0000 [STG/0] OUT -----> Installing glide 0.13.3  
             2021-10-20T23:33:14.86+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/f5e4affa54f8cf8e22cf524de5165a6e/glide-v0.13.3-linux-x64-cflinuxfs3-ef07acb5.tgz]  
             2021-10-20T23:33:15.34+0000 [STG/0] OUT -----> Installing dep 0.5.4  
             2021-10-20T23:33:15.34+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/f1900fcb2de60a12ea6743ecf05e14d2/dep-v0.5.4-linux-x64-cflinuxfs3-79b3ab9e.tgz]  
             2021-10-20T23:33:16.27+0000 [STG/0] OUT        [31;1m**ERROR**[0m Unable to determine Go version to install: no match found for 1.14.x in [1.15.13 1.15.14 1.16.5 1.16.6]  
             2021-10-20T23:33:16.36+0000 [STG/0] ERR Failed to compile droplet: Failed to run all supply scripts: exit status 16

Could I get some help bumping golang in the app to 1.16?

jyriok commented 2 years ago

work for me go 1.16 and go buildpack 1.9.37 :) just change it on manifest :

---
applications:
- name: gcp-service-broker
  memory: 1G
  buildpack: go_buildpack_v1_9_37
  env:
    GOPACKAGENAME: github.com/GoogleCloudPlatform/gcp-service-broker
    GOVERSION: go1.16
dsboulder commented 2 years ago

Interesting, I'm using the bosh-release to push the app, but the principal should be the same. I can't get it to build with golang 1.16 (and a slightly earlier buildpack version), but I can get it to build with 1.15. The error I get with 1.16 is:

             2021-11-18T19:46:20.77+0000 [STG/0] OUT Downloaded build artifacts cache (97.6M)  
             2021-11-18T19:46:21.63+0000 [STG/0] OUT -----> Go Buildpack version 1.9.34  
             2021-11-18T19:46:21.63+0000 [STG/0] OUT        [31;1m**WARNING**[0m buildpack version changed from 1.9.26 to 1.9.34  
             2021-11-18T19:46:21.63+0000 [STG/0] OUT        [31;1m**WARNING**[0m [DEPRECATION WARNING]:  
             2021-11-18T19:46:21.63+0000 [STG/0] OUT        [31;1m**WARNING**[0m Please use AppDynamics extension buildpack for Golang Application instrumentation  
             2021-11-18T19:46:21.63+0000 [STG/0] OUT        [31;1m**WARNING**[0m for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html  
             2021-11-18T19:46:21.66+0000 [STG/0] OUT -----> Installing godep 80  
             2021-11-18T19:46:21.66+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/52a892f00e80ca4fdcf27d9828c7aba1/godep-v80-linux-x64-cflinuxfs3-b60ac947.tgz]  
             2021-11-18T19:46:21.83+0000 [STG/0] OUT -----> Installing glide 0.13.3  
             2021-11-18T19:46:21.83+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/f5e4affa54f8cf8e22cf524de5165a6e/glide-v0.13.3-linux-x64-cflinuxfs3-ef07acb5.tgz]  
             2021-11-18T19:46:22.17+0000 [STG/0] OUT -----> Installing dep 0.5.4  
             2021-11-18T19:46:22.17+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/f1900fcb2de60a12ea6743ecf05e14d2/dep-v0.5.4-linux-x64-cflinuxfs3-79b3ab9e.tgz]  
             2021-11-18T19:46:22.45+0000 [STG/0] OUT -----> Installing go 1.16.6  
             2021-11-18T19:46:22.45+0000 [STG/0] OUT        Copy [/tmp/buildpacks/4619035bd41b14291cb9be8b7e8271fd/dependencies/66f74af1972bc800b00377849cd6f395/go_1.16.6_linux_x64_cflinuxfs3_7f9ac238.tgz]  
             2021-11-18T19:46:51.96+0000 [STG/0] OUT        Note: skipping (dep ensure) due to non-empty vendor directory.  
             2021-11-18T19:46:51.96+0000 [STG/0] OUT        [31;1m**WARNING**[0m Installing package '.' (default)  
             2021-11-18T19:46:51.96+0000 [STG/0] OUT -----> Running: go install -tags cloudfoundry -buildmode pie .  
             2021-11-18T19:46:52.34+0000 [STG/0] ERR go: cannot find main module, but found Gopkg.lock in /tmp/gobuildpack.gopath676967290/.go/src/github.com/GoogleCloudPlatform/gcp-service-broker  
             2021-11-18T19:46:52.34+0000 [STG/0] ERR to create a module there, run:  
             2021-11-18T19:46:52.34+0000 [STG/0] ERR go mod init  
             2021-11-18T19:46:52.34+0000 [STG/0] OUT        [31;1m**ERROR**[0m Unable to compile application: exit status 1  
             2021-11-18T19:46:54.40+0000 [STG/0] ERR Failed to compile droplet: Failed to run finalize script: exit status 12

I tried pushing the app directly and you're right it does run with just a change to GOVERSION=1.16, so I suspect there's some bosh/tile rebuilding thing that needs to happen as well. Would you all consider doing one last tile build with go 1.16 to buy another 6 months of ability to run with latest buildpacks while we shore up and switch to cloud service broker?