Closed LeonStoldt closed 2 years ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hi @LeonStoldt
That documentation is for calling gcr-cleaner-server via the API. In that case, underscores are correct. You can see the full list of flags and their accepted values for your version by running gcr-cleaner -h
.
Hi @sethvargo, thanks for your quick response and information about when to use underscores. I did not know that and was confused while working with the gcr cleaner in a github action. Do you think it would be useful to add example flags like `-tag-filter-any' to the github actions example in order to prevent confusion when using it?
Hi, When using gcr cleaner with argument
-tag_filter_any=.*
, I received an error message like:flag provided but not defined: -tag_filter_any
.I would guess the arguments have changed sometime and they haven't been updated in the Readme. So, I thought I'll create a PR to fix this :wink: