Closed Sytten closed 4 years ago
Do you have an example?
I mean, basically it would be a docker image that launches the cleaner with something like:
./gcp-cleaner --repo gcr.io/repo/test --allow-tagged
I guess I'm confused? Is there a reason the existing image at gcr.io/gcr-cleaner/gcr-cleaner
doesn't work for this use case?
The current image is running a web server and waits for a request right? Inside a CronJob you would directly execute the cleaning. Otherwise you need to keep a pod alive and do CronJob to ping it.
Ah I see. So you basically want two different binaries:
gcrcleaner-server
- gets requests and runs the cleanergcrcleaner-runner
- CLI that is invoked with flags and exists when doneIs that correct?
Exactly!
It would be nice to have a docker image for each too. And the second (gcrcleaner-runner
) could allow an override of CMD parameters so the k8s deployment can specify the flags.
I think I'll likely update the existing binary to support to commands server
and run
with appropriate flags.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
I think it would be valuable to create another entrypoint to directly run the cleaner with the specified parameters so it is possible to run inside GKE directly.