search

GoogleCloudPlatform / gcs-oauth2-boto-plugin

Auth plugin allowing use the use of OAuth 2.0 credentials for Google Cloud Storage in the Boto library.
Apache License 2.0
21 stars 38 forks source link

Fix support for oauth2client 2.0 #23

Closed romange closed 5 years ago

romange commented 8 years ago

Hello Google :)

gcs_oauth2_boto_plugin requires oauth2client==1.5.2 but latest google-api-python-client requires oauth2client 2.0. Otherwise it gives us the error below.

This PR adds the bindings that allow gcs_oauth2_boto_plugin to work with both oauth2client 1.5 and 2.0

WARNING:root:No module named contrib.locked_file
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/googleapiclient/discovery_cache/__init__.py", line 38, in autodetect
    from . import file_cache
  File "/usr/local/lib/python2.7/dist-packages/googleapiclient/discovery_cache/file_cache.py", line 32, in <module>
    from oauth2client.contrib.locked_file import LockedFile
ImportError: No module named contrib.locked_file
romange commented 8 years ago

Should fix #21

bivald commented 8 years ago

This worked for me

theacodes commented 8 years ago

Thanks for contributing, can you do me two things before I merge this?

  1. Sign the CLA and let @googlebot know.
  2. Update the tests.
emmanueljob commented 8 years ago

Thanks for this! 👍

bivald commented 8 years ago

@romange I'm merging several pull requests into one big, could you look into why @googlebot is not happy with your CLA? (otherwise I won't be able to send mine)

I've taken the liberty to att json() credential support (based on this pull request) as well

romange commented 8 years ago

@bivald My cla looks fine. Not sure why googlebot is not happy. How can I check it?

romange commented 8 years ago

@bivald It seems to work now. I just resigned it.

bivald commented 8 years ago

Awesome - thank you

On 8 juni 2016, at 20:40, romange notifications@github.com wrote:

@bivald It seems to work now. I just resigned it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.