GoogleCloudPlatform / gcs-oauth2-boto-plugin

Auth plugin allowing use the use of OAuth 2.0 credentials for Google Cloud Storage in the Boto library.
Apache License 2.0
21 stars 38 forks source link

Fix Python 3.x compatibility #34

Closed EmlynC closed 5 years ago

EmlynC commented 7 years ago

oauth2_client.py has some Python 2 syntax that is causing the module to fail when imported in Python 3.6 as referenced in issue #29 and #30. This is fixed by running 2to3 over oauth2_client.py and then correcting one things that 2to3 didn't catch — os.open expects a string for file mode rather than a unix mode octal.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


EmlynC commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

bharris47 commented 7 years ago

Any idea when this may be merged/released?

wmurphy commented 7 years ago

+1 on merging/releasing

zanes2016 commented 6 years ago

Any updates on the merge?

ccope commented 6 years ago

This module is now python 3 compatible, so this PR should be closed.

houglum commented 5 years ago

Just noticed we had a handful of PRs that never got triaged - apologies for letting this sit unactioned for so long :(

That being said, this module is indeed now PY3-compliant, so I'll go ahead and close this PR.