Closed EmlynC closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Any idea when this may be merged/released?
+1 on merging/releasing
Any updates on the merge?
This module is now python 3 compatible, so this PR should be closed.
Just noticed we had a handful of PRs that never got triaged - apologies for letting this sit unactioned for so long :(
That being said, this module is indeed now PY3-compliant, so I'll go ahead and close this PR.
oauth2_client.py
has some Python 2 syntax that is causing the module to fail when imported in Python 3.6 as referenced in issue #29 and #30. This is fixed by running2to3
overoauth2_client.py
and then correcting one things that 2to3 didn't catch —os.open
expects a string for file mode rather than a unix mode octal.