search

GoogleCloudPlatform / gcs-oauth2-boto-plugin

Auth plugin allowing use the use of OAuth 2.0 credentials for Google Cloud Storage in the Boto library.
Apache License 2.0
21 stars 38 forks source link

Add google-auth and google-auth-httplib2 to setup.py #68

Closed stanhu closed 2 months ago

stanhu commented 2 months ago

https://github.com/GoogleCloudPlatform/gcs-oauth2-boto-plugin/pull/62 added these dependencies to requirements.txt, but neglected to include them in setup.py. As a result, installing pip install gsutil doesn't automatically install these dependencies, resulting in:

File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module>
  from google_auth_httplib2 import Request as GoogleAuthRequest
ModuleNotFoundError: No module named 'google_auth_httplib2'

Closes #67

stanhu commented 2 months ago

@googlyrahman Could you review this?

googlyrahman commented 2 months ago

Thanks for bringing this to our attention, We were also discussing this internally, and decided to fix it.