GoogleCloudPlatform / gcsfuse

A user-space file system for interacting with Google Cloud Storage
https://cloud.google.com/storage/docs/gcs-fuse
Apache License 2.0
2.04k stars 421 forks source link

Revert "add squash to config structure tags to make decoding possible… #2058

Closed ashmeenkaur closed 3 months ago

ashmeenkaur commented 3 months ago

… from legacy flagStorage & mountConfig. (#2044)"

This reverts commit d4451a45b94d2e1480ab78a4d0c67c1be1c7a36e.

Reason: Found a better way to do the conversion. Did not realise earlier that with this approach, changes were required in legacy mount config and yaml v3 can't decode "squash" flags.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 72.03%. Comparing base (a1d8786) to head (4bcc5fe). Report is 334 commits behind head on master.

Files with missing lines Patch % Lines
cfg/config.go 0.00% 55 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2058 +/- ## ========================================== + Coverage 72.00% 72.03% +0.02% ========================================== Files 99 99 Lines 10869 10869 ========================================== + Hits 7826 7829 +3 + Misses 2711 2708 -3 Partials 332 332 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2058/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `72.03% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.