GoogleCloudPlatform / gcsfuse

A user-space file system for interacting with Google Cloud Storage
https://cloud.google.com/storage/docs/gcs-fuse
Apache License 2.0
2.04k stars 421 forks source link

small fix to read cache functional test #2065

Closed ashmeenkaur closed 2 months ago

ashmeenkaur commented 3 months ago

Description

TestConcurrentReads_ReadIsTreatedNonSequentialAfterFileIsRemovedFromCache is flaky. Asserting on length of structuredReadLogs will help narrow down the problem.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.98%. Comparing base (78b06ed) to head (9604a90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2065 +/- ## ========================================== + Coverage 71.96% 71.98% +0.01% ========================================== Files 99 99 Lines 10870 10870 ========================================== + Hits 7823 7825 +2 + Misses 2715 2713 -2 Partials 332 332 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2065/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `71.98% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.