GoogleCloudPlatform / gcsfuse

A user-space file system for interacting with Google Cloud Storage
https://cloud.google.com/storage/docs/gcs-fuse
Apache License 2.0
2k stars 413 forks source link

[CLI Config Parity] Migrate log severity and log format flags #2075

Closed ashmeenkaur closed 6 days ago

ashmeenkaur commented 1 week ago

Description

This PR is part of migration to new cobra/viper configs for CLI config parity. Replaced usage of log-format flag stored in flagstorage.LogFormat and mountConfig.LogConfig.Format to newConfig.Logging.Format. Replaced usage of mountConfig.LogConfig.Severity to newConfig.Logging.Severity.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Updated
  3. Integration tests - Ran via KOKORO
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.22%. Comparing base (bc27ee8) to head (e4a4606). Report is 3 commits behind head on master.

Files Patch % Lines
cfg/config.go 0.00% 5 Missing :warning:
cmd/legacy_main.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2075 +/- ## ========================================== - Coverage 72.27% 72.22% -0.06% ========================================== Files 100 101 +1 Lines 10952 10953 +1 ========================================== - Hits 7916 7911 -5 - Misses 2707 2713 +6 Partials 329 329 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2075/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2075/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `72.22% <50.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.