GoogleCloudPlatform / gcsfuse

A user-space file system for interacting with Google Cloud Storage
https://cloud.google.com/storage/docs/gcs-fuse
Apache License 2.0
2.04k stars 421 forks source link

Migrate a few flags to the new config #2089

Closed kislaykishore closed 3 months ago

kislaykishore commented 3 months ago

Description

Migrate the following flags to the new config:

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested manually to see that the flags are correctly being reflected.
  2. Unit tests - Existing unit-tests in legacy_param_mapper.go should already cover it.
  3. Integration tests - NA
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (8637ce1) to head (e1ee4c3). Report is 1 commits behind head on master.

Files Patch % Lines
cmd/mount.go 0.00% 18 Missing :warning:
cmd/legacy_main.go 30.76% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2089 +/- ## ========================================== - Coverage 72.25% 72.24% -0.01% ========================================== Files 101 101 Lines 10955 10956 +1 ========================================== Hits 7915 7915 - Misses 2711 2712 +1 Partials 329 329 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2089/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `72.24% <27.02%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.