codecov[bot]
commented
4 days ago Codecov Report
Attention: Patch coverage is 47.29730% with 39 lines in your changes missing coverage. Please review.
Project coverage is 71.47%. Comparing base (
ede5064) to head (82b639b). Report is 7 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...storage/caching/mock_gcscaching/mock_stat_cache.go | 0.00% | 35 Missing :warning: |
| internal/cache/metadata/stat_cache.go | 89.74% | 2 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2097 +/- ## ========================================== - Coverage 72.23% 71.47% -0.77% ========================================== Files 101 101 Lines 10956 12175 +1219 ========================================== + Hits 7914 8702 +788 - Misses 2713 3113 +400 - Partials 329 360 +31 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2097/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2097/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `71.47% <47.29%> (-0.77%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Adds insertFolder, AddNegativeEntryForFolder and lookup folder in stat cache for HNS buckets. This PR only adds new methods with corresponding implementations, currently these are not called from any bucket type.
Link to the issue in case of a bug fix.
NA
Testing details