GoogleCloudPlatform / gcsfuse

A user-space file system for interacting with Google Cloud Storage
https://cloud.google.com/storage/docs/gcs-fuse
Apache License 2.0
2k stars 413 forks source link

Fix default for experimental-grpc-conn-pool-size #2098

Closed kislaykishore closed 4 days ago

kislaykishore commented 4 days ago

Description

Change the default for experimental-grpc-conn-pool-size in the new config to 1.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Will be added in a follow-up PR
  3. Integration tests - NA
codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (43e4b64) to head (316d7cd).

Files Patch % Lines
cfg/config.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2098 +/- ## ========================================== + Coverage 71.93% 71.96% +0.02% ========================================== Files 101 101 Lines 10996 10996 ========================================== + Hits 7910 7913 +3 + Misses 2758 2755 -3 Partials 328 328 ``` | [Flag](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2098/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GoogleCloudPlatform/gcsfuse/pull/2098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `71.96% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.