GoogleCloudPlatform / generative-ai

Sample code and notebooks for Generative AI on Google Cloud, with Gemini on Vertex AI
https://cloud.google.com/vertex-ai/docs/generative-ai/learn/overview
Apache License 2.0
7.24k stars 1.95k forks source link

Establish consistency standards in notebooks around (colab vs workbench) #280

Closed zeroasterisk closed 1 week ago

zeroasterisk commented 10 months ago

Sometimes you have code blocks which are commented and you say to uncomment them, sometimes you have codeblocks which are uncommented and you say to comment them.

Instead, can we establish shared conventions for notebook set up, and ideally a runtime conditional allowing it to work in workbench and colab without editing. The fewer things a user needs to do to execute the colab, the better.

Other things to try to standardize on:

holtskinner commented 9 months ago

Related to this: We also should update the "Open In" Links to include Colab Enterprise, now that we can do that for notebooks in this repo. Not sure if we should replace Colab or Vertex AI Workbench or add another box.

URL Format: https://console.cloud.google.com/vertex-ai/colab/import/https:%2F%2Fraw.githubusercontent.com%2FGoogleCloudPlatform%2Fgenerative-ai%2Fmain%2Fgemini%2Fgetting-started%2Fintro_gemini_pro_vision_python.ipynb

gericdong commented 1 week ago

Thank you for the feedback! As @holtskinner commented above, there have been some discussions and work done to standardize notebook style across multiple runtimes. We are tracking the progress in those workstreams. As such we can close this request here.