GoogleCloudPlatform / gke-autoneg-controller

This GKE controller provides simple custom integration between GKE and GCLB.
Apache License 2.0
159 stars 50 forks source link

Make it possible to reattach NEGs automatically #106

Closed fdfzcq closed 10 months ago

fdfzcq commented 11 months ago

The current behaviour of Autoneg introduces race conditions for us, the scenario goes:

The proposed solution here without us doing big architectural change is to make Autoneg reconcile periodically. Since this is a big behaviour change, I added a flag to enable it but defaults to false. Along with another flag to configure the reconciliation period.

rosmo commented 11 months ago

Don't get me wrong, I support this, but couldn't the user just delete the status annotation to re-reconcile?

fdfzcq commented 11 months ago

@rosmo Yes, that was a workaround, but it adds toils. And we think this kind of mishaps can happen without users notice and cause incident.

fdfzcq commented 10 months ago

@rosmo Hello, could you re-review the PR? :D

rosmo commented 10 months ago

LGTM

joshw123 commented 7 months ago

Hello, Do you know when this will be released? :) Thank You!

rosmo commented 7 months ago

@joshw123 I'll roll out a new pre-release after issue in #113 is solved.