search

GoogleCloudPlatform / gke-autoneg-controller

This GKE controller provides simple custom integration between GKE and GCLB.
Apache License 2.0
159 stars 50 forks source link

Unused ConfigMap in deploy manifest #96

Closed jawnsy closed 11 months ago

jawnsy commented 1 year ago

The deploy manifest includes a ConfigMap that does not appear to be used (it is not mounted to the Deployment). Can it be removed?

https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/b8b9a87c65f3bfc07aebc60649b4f5c4af7d3230/deploy/autoneg.yaml#L189-L222

rosmo commented 1 year ago

Yeah, I don't think that is important - happy to take a patch to remove it. I think it made it's way into the Terraform example as well.