search

GoogleCloudPlatform / gke-managed-certs

Managed Certificates for Kubernetes clusters using GCLB
Apache License 2.0
246 stars 32 forks source link

Rebase gke-certificate-controller image to distroless #17

Closed yuwenma closed 5 years ago

yuwenma commented 5 years ago

As part of the effort described in KEP:Rebase images to distroless, we need to rebase gke-certificate-controller image to distroless.

The action items include:

  1. Replace glog to klog in the source code.
  2. Remove shell dependencies in Dockerfile: run.sh pipes the stdout and redirects the log to /var/log/managed_certificate_controller.log. After klog is applied, we can use klog flag "--log-file=/var/log/managed_certificate_controller.log" to replace the shell cmd and then no bash script is required.
yuwenma commented 5 years ago

/cc @michallowicki /cc @krzykwas This effort is targeting v1.15 (around Jun). Can you help finding a good owner?

krzykwas commented 5 years ago

This repo only exposes gke-internal repo publicly, so any changes need to be made there first. I'm sure we don't have to discuss priorities for this and other projects publicly. Please reach out to mbwalas@ for prioritization.

krzykwas commented 5 years ago

This effort is tracked internally to Google, closing this thread.