GoogleCloudPlatform / gke-managed-certs

Managed Certificates for Kubernetes clusters using GCLB
Apache License 2.0
246 stars 32 forks source link

Support more then one domain #29

Closed fkorotkov closed 4 years ago

fkorotkov commented 5 years ago

spec.domains should support a list of domains since it doesn't support wildcard domains.

Right now it ends up in an error:

spec.domains in body should have at most 1 items
fkorotkov commented 5 years ago

Workaround for now is to use multiple managed certificates and use them all in networking.gke.io/managed-certificates (comma separated).

vrobert78 commented 5 years ago

Indeed it will be very interesting. It will avoid FailedRateLimited status when creating a lot of domains in the same week...

mattKaczorowski commented 4 years ago

:+1: Considering Google Managed Certificates outside of the context of K8S does have SAN support, I don't see why we cannot have this :)

mattKaczorowski commented 4 years ago

This problem is made worse by the 15 cert limit. https://github.com/GoogleCloudPlatform/gke-managed-certs/issues/41

mattKaczorowski commented 4 years ago

It looks like the most recent commit to master does what we want. I have attempted to use the new API version with the latest release of GKE. It looks like it has not been rolled out. Any chance getting this pushed out to GKE?

https://github.com/GoogleCloudPlatform/gke-managed-certs/commit/a6734bb729e563986bddf0dac70ac3a2788661b5

@krzykwas

krzykwas commented 4 years ago

The multi-SAN support has been already launched to GKE staging and should be available soon. :)

I won't give any specific promises about the exact time when this rolls out, as there could always happen a delay.

mattKaczorowski commented 4 years ago

Awesome, thank you! I cannot wait :slightly_smiling_face:

innocode-devops commented 4 years ago

@krzykwas hi there, is there approx ETA of release the multi-SAN support?

krzykwas commented 4 years ago

GKE 1.16.5-gke.1+ supports multi-SAN using ManagedCertificate v1beta2

innocode-devops commented 4 years ago

@krzykwas Thanks a lot