GoogleCloudPlatform / gke-managed-certs

Managed Certificates for Kubernetes clusters using GCLB
Apache License 2.0
246 stars 32 forks source link

Fix README.md file and add rbac.yaml description #4

Closed michael34435 closed 5 years ago

michael34435 commented 5 years ago

I’ve modified README file and add some descriptions

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
michael34435 commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

krzykwas commented 5 years ago

Hello! Thank you for spotting and fixing the errors. Because of the way the code of this project is developed right now, this pull request unfortunately cannot be directly merged - the code is developed in an internal repository and then only pushed here. I've fixed the errors you've found, though. Thank you!