search

GoogleCloudPlatform / gke-network-policy-demo

This guide demonstrates how to improve the security of your Kubernetes Engine by applying fine-grained restrictions to network communication. You will provision a simple HTTP server and two client pods in a Kubernetes Engine cluster, then use a Network Policy restrict connections from client pods.
Apache License 2.0
99 stars 85 forks source link

Remove cert outputs from terraform #16

Closed venkayya closed 5 years ago

google-oss-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: techgnosis

If they are not already assigned, you can assign the PR to them by writing /assign @techgnosis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/gke-network-policy-demo/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
venkayya commented 5 years ago

test this

chrislovecnm commented 5 years ago

/lgtm

google-oss-robot commented 5 years ago

@chrislovecnm: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to [this](https://github.com/GoogleCloudPlatform/gke-network-policy-demo/pull/16#issuecomment-450009070): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chrislovecnm commented 5 years ago

Test this please

chrislovecnm commented 5 years ago

This should have passed by now. Please research

venkayya commented 5 years ago

test this please

venkayya commented 5 years ago

this has been passing CI but status is not getting updated

venkayya commented 5 years ago

test this please

emailbob commented 5 years ago

Try updating validate.sh with !/bin/bash -e at the top and then running it locally. The script is bombing out after step 2

venkayya commented 5 years ago

this PR passed CI