Closed swathiswaminathan closed 5 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: techgnosis
If they are not already assigned, you can assign the PR to them by writing /assign @techgnosis
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
test this please
@swathiswaminathan CI is not happy. Please look at it
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
test this please.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
@swathiswaminathan why is this failing in CI? Please take a look at Jenkins.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
Closed and reopened new PR
Made the below changes in the PR: