Open homernajafi opened 5 years ago
Can one of the admins verify this patch?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi @homernajafi. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: homernajafi To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: chrislovecnm
If they are not already assigned, you can assign the PR to them by writing /assign @chrislovecnm
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
Not passing CI, can you please check on why
As per Robin's comment adding steps for implementing network policy based on namespace and validate it.