search

GoogleCloudPlatform / gke-networking-api

Apache License 2.0
9 stars 10 forks source link

Update ready conditions for GKENetworkParamSet #11

Closed synth-beat closed 4 months ago

synth-beat commented 5 months ago

Adding status conditions to be used for validation updates for GNPs with NetworkAttachment.

synth-beat commented 5 months ago

@shouri please review

synth-beat commented 4 months ago

@mskrocki @aojea

bowei commented 4 months ago

/assign @mskrocki

mskrocki commented 4 months ago

/lgtm /approved

shouri007 commented 4 months ago

/lgtm /approve

synth-beat commented 4 months ago

@aojea Can you help get this in? Maciej's approval doesn't seem to count for write access, even though he's in the OWNERS.

synth-beat commented 4 months ago

@bowei Are you able to help merge this in?

aojea commented 4 months ago

@yswe can you sync with @bowei and @synth-beat to find a model of approval that fits current teams structures?

I prefer to not be in the critical path of possible

aojea commented 4 months ago

I think the problem is that this repo uses GitHub approvals, you need to approve in the GitHub code review button Screenshot_20240702-194512