search

GoogleCloudPlatform / gke-networking-api

Apache License 2.0
9 stars 10 forks source link

Parsing annotation should not return partial results #42

Open YifeiZhuang opened 5 days ago

YifeiZhuang commented 5 days ago

Parsing annotation should not return partial results, needs to be fixed to something like:

if err := json.Unmarshal(); err != nil { return InterfaceStatusAnnotation{}, err }
return ret, nil

https://github.com/GoogleCloudPlatform/gke-networking-api/blob/898f6b4a2a34a04108bd6bf66773cf2221c2e511/apis/network/v1/annotations.go#L213-L252

YifeiZhuang commented 5 days ago

/assign @liuyuan10