search

GoogleCloudPlatform / gke-networking-recipes

Apache License 2.0
307 stars 85 forks source link

Migrate examples with MultiClusterService to use ServiceExport #103

Closed briantkennedy closed 1 year ago

briantkennedy commented 2 years ago

MultiClusterService is now superseded by ServiceExport. We should convert all example usage of MultiClusterService to use ServiceExport so GKE users are not funneled down a path which will no longer be actively developed.

https://cloud.google.com/kubernetes-engine/docs/how-to/multi-cluster-services#using-mcs

Current usage:

gke-networking-recipes$ git grep -n "kind: MultiClusterService" 
ingress/multi-cluster/mci-asm-https-e2e/README.md:99:kind: MultiClusterService
ingress/multi-cluster/mci-asm-https-e2e/mci-mcs.yaml:13:kind: MultiClusterService
ingress/multi-cluster/mci-basic/README.md:73:kind: MultiClusterService
ingress/multi-cluster/mci-basic/ingress.yaml:27:kind: MultiClusterService
ingress/multi-cluster/mci-basic/ingress.yaml:43:kind: MultiClusterService
ingress/multi-cluster/mci-basic/ingress.yaml:61:kind: MultiClusterService
ingress/multi-cluster/mci-blue-green-cluster/README.md:61:kind: MultiClusterService
ingress/multi-cluster/mci-blue-green-cluster/README.md:82:kind: MultiClusterService
ingress/multi-cluster/mci-blue-green-cluster/ingress.yaml:21:kind: MultiClusterService
ingress/multi-cluster/mci-blue-green-cluster/ingress.yaml:42:kind: MultiClusterService
ingress/multi-cluster/mci-frontend-config/README.md:98:kind: MultiClusterService
ingress/multi-cluster/mci-frontend-config/ingress.yaml:31:kind: MultiClusterService
ingress/multi-cluster/mci-frontend-config/ingress.yaml:47:kind: MultiClusterService
ingress/multi-cluster/mci-frontend-config/ingress.yaml:65:kind: MultiClusterService
ingress/multi-cluster/mci-https-e2e/README.md:92:kind: MultiClusterService
ingress/multi-cluster/mci-https-e2e/ingress.yaml:30:kind: MultiClusterService
ingress/multi-cluster/mci-https-e2e/ingress.yaml:49:kind: MultiClusterService
ingress/multi-cluster/mci-https-e2e/ingress.yaml:68:kind: MultiClusterService

Examples needing migration:

boredabdel commented 2 years ago

Thanks for the issue. I will look into it.

Starting which version of GKE is the new CRD available ?

briantkennedy commented 2 years ago

ServiceExport went GA on 2021-02-16. I'm having trouble finding which GKE version it targeted, but the Rapid channel was version 1.18 at the time, so we can safely assume that GKE 1.19+ is supported.

boredabdel commented 1 year ago

Hi Brian,

I started looking into this today and i'm a bit confused.

The documentation you shared seems to talk about exporting Services across clusters for Service Discovery Purposes.

But for MultiClusterIngress use-cases (which one it's examples is ingress/multi-cluster/mci-basic/). It seems like MultiClusterService is still in use https://cloud.google.com/kubernetes-engine/docs/how-to/multi-cluster-ingress

is my understanding correct or did i miss something ?

boredabdel commented 1 year ago

Ok So i did some digging and walked throught the example. They are all using MCS in the context of MCI. Not as a mean for x cluster Service Discovery which would require us to migrate toward the ServiceExport crd.

Closing this issue.