Closed songrx1997 closed 1 year ago
Hey @bowei, could you review this? Thanks!
Hi,
Is the review on this urgent ? Can it wait few weeks ?
/assign
cc @swetharepakula
Please split the automatic code updates (e.g. go mod vendor etc) from the human changes into separate commits. If you can setup a session (10 minutes) to walk through and demo the tests, that would be useful...
Hi @bowei , just addressed your comments. Could you review this? Thanks
Generally the change looks good. Ping when the comments are resolved.
Seems like some lint rules failed for links in vendor not found. Can we ignore these checks for /vendor?
Can we fix the doc linting OR state explicitly that it won't pass and why. Otherwise looks ok.
Can we fix the doc linting OR state explicitly that it won't pass and why. Otherwise looks ok.
Hi @bowei, just removed all the .md files in vendor. All checks passed.
I think the solution is not the delete the files but to ignore the files in vendor/
from the lint....
Can we fix the doc linting OR state explicitly that it won't pass and why. Otherwise looks ok.
Hi @bowei, just removed all the .md files in vendor. All checks passed.
You should change:
.github/workflows/documentation.yaml
jobs:
linting:
name: Documentation linting
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Markdown links
uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.mlc_config.json'
base-branch: main
folder-path:
- archive
- gateway
- gateway-api
- ingress
- service-directory
- services
file-path:
- cluster-setup.md
- CONTRIBUTING.md
- README.md
@songrx1997 -- can you trigger a new test run to check that we got rid of the markdown errors?
@songrx1997 -- can you trigger a new test run to check that we got rid of the markdown errors?
@bowei file checks passed
This PR creates a testing framework which will handle the following for future recipe prow tests: