search

GoogleCloudPlatform / gke-networking-recipes

Apache License 2.0
307 stars 85 forks source link

Create yaml parser #143

Closed sawsa307 closed 1 year ago

sawsa307 commented 1 year ago

Use controller-runtime client to manage k8s resources.

sawsa307 commented 1 year ago

/assign @bowei @boredabdel

bowei commented 1 year ago

Looks like there is a huge vendor change? Is it possible to make the vendor change separate PR first (just checkout the repo and run go mod tidy, go mod vendor etc).

sawsa307 commented 1 year ago

Looks like there is a huge vendor change? Is it possible to make the vendor change separate PR first (just checkout the repo and run go mod tidy, go mod vendor etc).

Yes. Create #147 for vendor change, and this PR only creates the yaml parse.

bowei commented 1 year ago

Please rebase

sawsa307 commented 1 year ago

Please rebase

Rebased. Please take a look. Thanks!

bowei commented 1 year ago

This should be the last review.

Please close any comment threads that have been resolved.