GoogleCloudPlatform / gke-networking-recipes

Apache License 2.0
307 stars 86 forks source link

Create test for ingress for custom default backend. #145

Closed sawsa307 closed 1 year ago

sawsa307 commented 1 year ago

Create test for ingress for custom default backend.

bowei commented 1 year ago

I thought the purpose of the code is to test the YAMLs checked in, not to write more e2e tests?

sawsa307 commented 1 year ago

I thought the purpose of the code is to test the YAMLs checked in, not to write more e2e tests?

Do you mean we only want to check if the yaml files are syntactically correct? We don't need to create and validate the resources created by yaml?

sawsa307 commented 1 year ago

I thought the purpose of the code is to test the YAMLs checked in, not to write more e2e tests?

Yes it is getting into a more e2e test format, but we might fail to check many cases if we only check the yaml creates the corresponding objects, so validating traffic would be more a comprehensive check.